Young-Seok Kim has posted comments on this change. Change subject: Set LSMRTreeWithAntiMatterTuples as the default RTree for interal dataset ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/838/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java: Line 321: IIndexDataflowHelperFactory idff = null; > Why the set to null then initialize here? Also I guess I am trying to under I changed the code not to have the null initialization. getComparatorFactoriesForDeletedKeyBTree() is for the deleted-key-btree of the in-memory component. Again, still, LSMRTreeWithAntimatterTuples maintains a deleted-key-btree for the in-memory component. So, this is not about backwards compat. https://asterix-gerrit.ics.uci.edu/#/c/838/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java: Line 376: protected LSMRTreeOpContext createOpContext(IModificationOperationCallback modCallback, > What's the purpose of this new callback? Is it because the antimatter RTree This was a bug which doesn't provide a proper search callback. So, I fixed it. -- To view, visit https://asterix-gerrit.ics.uci.edu/838 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19323ef38335409bc914265502ae56655db6d106 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Young-Seok Kim <kiss...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-HasComments: Yes
