Wenhai Li has posted comments on this change. Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype based on parallel streaming histogram. ......................................................................
Patch Set 14: (6 comments) Yep. Our first step should be to integrate the streaming histogram into the aggregation functions and then set up the specific operator and compiler guidance which may need another talk since the current aggregationFunc based roadmap is a bit different from our original hyracks-level implementation. https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/global-rg/global-avg.1.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/global-rg/global-avg.1.adm: Line 1: [ ] > Why is the result empty? This seems like a bad test. Why create a range que Since, the single local/global range function has no sense for our current requirement, these two cases expect the "not defined functions" error for the future extension. https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/local-rg/local-rg.1.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/local-rg/local-rg.1.adm: Line 1: [ ] > Why is the result empty? Same as above. https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarRangeGeneratorAggregateDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarRangeGeneratorAggregateDescriptor.java: Line 29: public final static FunctionIdentifier FID = AsterixBuiltinFunctions.SCALAR_RG; > Do you need this variable FID? Can this be inlined? We are not sure whether the range generator need to be treated as the scalarFunc as the other aggregates do. Just give it here for sake of completeness. https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/GlobalRangeGeneratorAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/GlobalRangeGeneratorAggregateFunction.java: Line 85: translateVal = new BytePointable(); Will enforce it by the factory. https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java: Line 89: translateVal = new BytePointable(); > Use factory to create pointable. Done https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeGeneratorAggregateFunction.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeGeneratorAggregateFunction.java: Line 46: // TODO Auto-generated method stub > Are these still in progress? Nop, similar to the scalar function, this function is kept for extension. In the current setting, this class has no sense. Just Global/Local rangegenerator are enough to compute/merge the histogram. -- To view, visit https://asterix-gerrit.ics.uci.edu/806 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <lwhaym...@yahoo.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Preston Carman <prest...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Wenhai Li <lwhaym...@yahoo.com> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Yingyi Bu <ying...@google.com> Gerrit-HasComments: Yes
