Young-Seok Kim has posted comments on this change. Change subject: Make job recovery memory configurable ......................................................................
Patch Set 3: (1 comment) Please address a comment regarding comments :) https://asterix-gerrit.ics.uci.edu/#/c/852/3/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/StorageUtil.java File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/StorageUtil.java: Line 73: Plz add comments and an example for the return value considering that the method actually round down (floor()) the numbers to one decimal place, not the round(round()). formatSize(1024L * 1024L * 10L) -> "10.0 MB" formatSize(1024L * 1024L * 1024l * 10L) -> "10.0 GB" formatSize((1024L * 1024L * 1024l * 10L *) + 1024l * 1024l * 100) -> "10.1 GB" formatSize((1024L * 1024L * 1024l * 10L *) + 1024l * 1024l * 50) -> "10.0 GB" BTW, is it better to apply round() instead of floor()? -- To view, visit https://asterix-gerrit.ics.uci.edu/852 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief359eae2352408c0cbfd37b0e3a1e758c78e0dd Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
