Murtadha Hubail has posted comments on this change. Change subject: ASTERIXDB-1425 & ASTERIXDB-1450: Fix LogReader random reads ......................................................................
Patch Set 2: (6 comments) @Young-Seok, Changed to 256MB. https://asterix-gerrit.ics.uci.edu/#/c/867/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: Line 212: } catch (InterruptedException e) { > CRITICAL SonarQube violation: Done Line 362: if (txnLogFileId2ReaderCount.containsKey(id)) { > MAJOR SonarQube violation: Done Line 363: if (txnLogFileId2ReaderCount.get(id) > 0) { > MAJOR SonarQube violation: Done Line 549: RandomAccessFile raf = new RandomAccessFile(new File(logFilePath), "r"); > BLOCKER SonarQube violation: This file should be closed by the caller of this method https://asterix-gerrit.ics.uci.edu/#/c/867/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogReader.java: Line 227: } catch (InterruptedException e) { > CRITICAL SonarQube violation: Done Line 264: case TRUNCATED: { > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/867 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c75ca4a7c8fe197451126392389d4baecbd7e45 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-HasComments: Yes
