skrawcz opened a new pull request, #602:
URL: https://github.com/apache/burr/pull/602
This proposes a new hook to allow one to remotely push execution of a Burr
Action.
For example, if one wants to selectively push remote execution of an action
to say Ray,
then one can now build an interceptor.
This also introduces companion hooks that would run pre & post on the remote
to mirror
what Burr has today - -I thought it would be simpler to not try to reuse
those hooks, and
instead make it explicit as to what is going on if you wanted to add
something similar.
See tests for examples, but open to feedback here.
Note: we'd need to think through how this plays with parallelism
functionality we have.
E.g. currently interceptors aren't propagated to sub applications...
## Changes
- adds to internal hooks to intercept an action and remotely execute it
- adds ray example
## How I tested this
- [ ] NEEDS EXTENSIVE TESTING
- [ ] Test sync
- [ ] Test async
- [ ] Test async streaming
- [ ] Test sync streaming
- [x] I ran some ray examples
- [ ] need to write another interceptor for another backend, e.g. temporal
to feel it out.
## Notes
This change needs to have some thought and discussion.
## Checklist
- [ ] PR has an informative and human-readable title (this will be pulled
into the release notes)
- [ ] Changes are limited to a single goal (no scope creep)
- [ ] Code passed the pre-commit check & code is left cleaner/nicer than
when first encountered.
- [ ] Any _change_ in functionality is tested
- [ ] New functions are documented (with a description, list of inputs, and
expected output)
- [ ] Placeholder code is flagged / future TODOs are captured in comments
- [ ] Project documentation has been updated if adding/changing
functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
