majiayu000 opened a new pull request, #614:
URL: https://github.com/apache/burr/pull/614
## Summary
- Fixed uninformative KeyError when pydantic_action has untyped state
parameter
- Now raises clear ValueError explaining the state parameter must be
annotated
## Changes
- Changed `type_hints["state"]` to `type_hints.get("state")` to avoid
KeyError
- Updated error message to clearly state: "'state' parameter must be
annotated with a type extending pydantic.BaseModel"
## Test plan
- [x] Added test function `_fn_with_untyped_state_arg` and parameterized
test case
- [x] Added
`test__validate_and_extract_signature_types_untyped_state_error_message` to
verify error message
- [x] All existing pydantic tests pass (32 tests)
- [x] Pre-commit checks pass
Closes #385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
