Smitaambiger commented on PR #632: URL: https://github.com/apache/burr/pull/632#issuecomment-3773773401
@skrawcz Thanks for the review! I’ve addressed the requested cleanup and test failure: - Implemented `list_app_ids` on `FakeStateLoader` to satisfy the abstract base class - Updated the test to respect `initialize_from` entrypoint rules - Simplified the `override_state_values` check as suggested - Removed unnecessary inline imports I verified the change locally with: ```bash pytest tests/core/test_application.py -k override_state_values -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html ======== 1 passed, 124 deselected, 2 warnings in 0.60s ========= -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
