Smitaambiger commented on PR #656:
URL: https://github.com/apache/burr/pull/656#issuecomment-3949564905
@skrawcz ,Thanks for the detailed feedback!
Addressed the requested changes:
- Moved imports to top level
- Consolidated tests into `test_action.py`
- Added test for multiple undeclared keys interleaved with declared keys
- Added regression test to ensure pydantic-based actions are not impacted
- Cleaned up lint/formatting issues
**Core tests are passing locally and CI should reflect the same.**
```
(.venv) PS C:\Users\gouta\OneDrive\Desktop\burr> python -m pytest tests/core
-q
.................................................................................................................................................................................................
[ 69%]
....................................................................................
[100%]
277 passed in 9.10s
```
```
(.venv) PS C:\Users\gouta\OneDrive\Desktop\burr> pre-commit run --all-files
black....................................................................Passed
trim trailing
whitespace.................................................Passed
fix end of
files.........................................................Passed
fix
requirements.txt.....................................................Passed
check python
ast.........................................................Passed
isort....................................................................Passed
flake8...................................................................Passed
frontend-lint-staged.....................................................Passed
```
Please let me know if any further adjustments are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
