Github user sesuncedu commented on the pull request:
https://github.com/apache/commons-compress/commit/fde66702c33d3888b682adc7e6c35dd21cb1e8da#commitcomment-22956878
In
src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java:
In
src/main/java/org/apache/commons/compress/archivers/zip/NioZipEncoding.java on
line 146:
I now know definitively that jdk 8 throws an IllegalArgumentException if
there's an underflow when decoding a zip string.
I learned that this morning when I checked a job I started last night, and
found it had died because I was only catching IOExceptions. Grrr.
This is why I am so consistently in favor of checked exceptions except for
all the times when I'm not :)
I probably switched to using an assert instead of throwing an exception
because of coveralls, which is very good at discouraging runtime error checks
that are easy to code but really hard to generate (the lack of any way to tell
it to ignore statements is a major flaw).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
