GitHub user stevebosman opened a pull request:
https://github.com/apache/commons-numbers/pull/18
[NUMBERS-56] Fix dimension check and a couple of other bugs found.
Started as a fix to the Jira task, but while adding unit tests I discovered
a couple more bugs. I also fixed checkstyle issues and standardised to Java
style array declarations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevebosman/commons-numbers master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-numbers/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit cfa71fc12f6a48d1d37e7e389a025dc8cea971b6
Author: Steve Bosman <stevebosman@...>
Date: 2018-12-07T11:48:28Z
[NUMBERS-56] Fix dimension check; improve test coverage and fix other bugs
found.
commit bd8d91cfe0cc15e0b695b00fcfc43d5d8b627aa4
Author: Steve Bosman <stevebosman@...>
Date: 2018-12-07T12:42:02Z
NUMBERS-56 Add missing unit tests and fix a couple of bugs in ComplexUtils
(tidy up test array creation)
----
---
