westonpace commented on code in PR #189: URL: https://github.com/apache/comdev-site/pull/189#discussion_r1824491032
########## source/templates/pmc-member-invite.txt: ########## @@ -0,0 +1,23 @@ +To: [Candidate Email Address] +Cc: private@[PROJECT].apache.org +Subject: Invitation to become [PROJECT] PMC member: [PMC Member Name] + +Hello [invitee name], + +The [Project] Project Management Committee (PMC) +hereby offers you membership in the PMC. These privileges are offered on +the understanding that you'll use them reasonably and with common sense. +We like to work on trust rather than unnecessary constraints. + +This personal invitation is a chance for you to accept or decline in private. +Please let us know in reply to this message whether you accept or decline. + +The rights and responsibilities are described here: +https://community.apache.org/pmc/responsibilities.html +If that's in any way unclear, please reach out to me or any of the Review Comment: ```suggestion If that's in any way unclear, please reach out to me or any of the ``` ########## source/newpmcmember.md: ########## @@ -1,47 +1,76 @@ --- -title: New PMC member +title: Inviting a New PMC member tags: ["pmc", "pmcmembers", "election"] --- -## New PMC member process +This document describes a typical Apache project's process for handling the +vote to add a new PMC (Project Management Committee) member - when it is +separate from becoming committer. -This section describes a typical Apache project's process for handling the -vote to add a new PMC member - when it is separate from becoming committer. -Templates mentioned in the process appear later in this document. If your PMC -adds automatically committers as PMC members, the process for doing both at the -same time is described in the [New committer](https://community.apache.org/newcommitter.html) -The [Contributor Ladder](https://community.apache.org/contributor-ladder.html) helps explain different roles. +Templates mentioned in the process appear [#NewPMCMember-EmailTemplates](later in +this document). If your PMC adds automatically committers as PMC members, the process +for doing both at the same time is described in the [New +committer](https://community.apache.org/newcommitter.html) advice. +The [Contributor Ladder](https://community.apache.org/contributor-ladder.html) helps +explain different roles. + +{{% toc %}} <a name="NewPMCMember-Summary"></a> -### Summary +## TL;DR - Inviting a new PMC member -1. Discuss the proposed PMC member. If the discussion seems to be going positively, call a vote following - the template below. -1. Close the vote following the template below. -1. If the result is positive, invite the new committer following the template below. +1. Discuss the proposed PMC member. (Use [this template](templates/pmc-member-discuss.txt).) +1. If the discussion seems to be going positively, call a vote. (Use + [this template](templates/pmc-member-vote.txt).) +1. Close the vote. (Use [this template](templates/pmc-member-results.txt).) +1. If the result is positive, invite the new committer. (Use [this + template](templates/pmc-member-invite.txt).) If they accept, then: -1. In case the new PMC member is already is already a committer, they have Apache id, - you should grant them appropriate PMC privileges. Use the Whimsy tool to update the roster via - https://whimsy.apache.org/roster/committee/ or https://whimsy.apache.org/roster/ppmc/ -1. Announce the new PMC member following the template below. +1. If the new PMC member is already is already a committer, and they have Apache id, Review Comment: ```suggestion 1. If the new PMC member is already a committer, and they have Apache id, ``` ########## source/templates/pmc-member-results.txt: ########## @@ -0,0 +1,16 @@ +To: private@[PROJECT].apache.org +Subject: [RESULT] [VOTE] New PMC member: [Candidate Name] + +The vote has now closed. The results are: + +Binding Votes: + Review Comment: ```suggestion ``` If each line mentions `binding` and `non-binding` then I don't think this is just a list of "Binding Votes:". Also, it is a bit odd to have two colon-terminated statements in a row. ########## source/templates/pmc-member-welcome.txt: ########## @@ -0,0 +1,22 @@ +To: private@[PROJECT].apache.org, [PMC member ID]@apache.org +Subject: Welcome to the PMC, [First Name] + +Hello, [PMC Member], + +Welcome to the [Project] Project Management Committee. As a PMC +member, you now are empowered help make decisions about, and guide the +future of, our project. + +Please subscribe to the [PROJECT] Project Management +Committee mailing list private@[PROJECT].apache.org. Do this by +sending an empty email to private-subscribe@[PROJECT].apache.org and +follwing the instructions in the automated response you'll receive. Review Comment: I thought PMC members were automatically subscribed but this is just my memory and not any concrete knowledge of the process so I'm likely wrong. ########## source/templates/pmc-member-vote.txt: ########## @@ -0,0 +1,20 @@ +To: private@[PROJECT].apache.org +Subject: [VOTE] New PMC Member: [Candidate Name] + +This is a VOTE to add [Candidate Name] as a PMC member. + +This has been discussed here: +[Link to DISCUSS thread on lists.apache.org] +If you have more to add to the discussion, please do so there, rather than +in this VOTE thread. + +[+1] Yes, add this committer +[0] Abstain +[-1] No, do not add this committer Review Comment: ```suggestion [+1] Yes, add this person to the PMC [0] Abstain [-1] No, do not add this person to the PMC ``` ########## source/templates/committer-discuss.txt: ########## @@ -1,4 +1,4 @@ -To: priv...@project.apache.org +To: private@[project].apache.org Review Comment: ```suggestion To: private@[PROJECT].apache.org ``` For consistency with the other templates ########## source/templates/pmc-member-invite.txt: ########## @@ -0,0 +1,23 @@ +To: [Candidate Email Address] +Cc: private@[PROJECT].apache.org +Subject: Invitation to become [PROJECT] PMC member: [PMC Member Name] + +Hello [invitee name], + +The [Project] Project Management Committee (PMC) +hereby offers you membership in the PMC. These privileges are offered on +the understanding that you'll use them reasonably and with common sense. +We like to work on trust rather than unnecessary constraints. + +This personal invitation is a chance for you to accept or decline in private. +Please let us know in reply to this message whether you accept or decline. + +The rights and responsibilities are described here: +https://community.apache.org/pmc/responsibilities.html +If that's in any way unclear, please reach out to me or any of the +other PMC members for clarification, or to discuss this decision in more +detail. Review Comment: ```suggestion other PMC members for clarification, or to discuss the role in more detail. ``` I'm not sure there is much discussion to be had on the decision is there? ########## source/newpmcmember.md: ########## @@ -1,47 +1,76 @@ --- -title: New PMC member +title: Inviting a New PMC member tags: ["pmc", "pmcmembers", "election"] --- -## New PMC member process +This document describes a typical Apache project's process for handling the +vote to add a new PMC (Project Management Committee) member - when it is +separate from becoming committer. -This section describes a typical Apache project's process for handling the -vote to add a new PMC member - when it is separate from becoming committer. -Templates mentioned in the process appear later in this document. If your PMC -adds automatically committers as PMC members, the process for doing both at the -same time is described in the [New committer](https://community.apache.org/newcommitter.html) -The [Contributor Ladder](https://community.apache.org/contributor-ladder.html) helps explain different roles. +Templates mentioned in the process appear [#NewPMCMember-EmailTemplates](later in +this document). If your PMC adds automatically committers as PMC members, the process Review Comment: ```suggestion this document). If your PMC automatically adds committers as PMC members, the process ``` Minor nit but I believe `add` is being used transitively here and the adverb comes first. ########## source/templates/pmc-member-discuss.txt: ########## @@ -0,0 +1,17 @@ +To: private@[project].apache.org +Subject: [DISCUSS] New PMC member: [Candidate Name] + +I propose to add [Candidate Name] as a PMC member. + +[State reasons that you believe they are a good candidate] + +[State contribution statistics, if available and relevant.] + +PMC members are our peers, who help drive the direction of this +project. They will be owners not just of the code, but of the project +and its brand. + +Please remember that should this candidate be elected, they will have +access to our archives, and be able to read this, so phrase your +comments constructively with this in mind. Review Comment: I'm not sure if this is universally true. At least for the Arrow project I don't believe I am able to browse the archives before I was accepted. Though I agree things should be kept constructive in either case and so I don't think it's harmful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@community.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
