ShaneCurcuru commented on code in PR #191: URL: https://github.com/apache/comdev-site/pull/191#discussion_r1826558031
########## source/pmc/adding-committers.md: ########## @@ -3,21 +3,61 @@ title: Adding Committers tags: ["pmc","committers"] --- -The addition of committers is essential to the long-term -sustainability of an open source project. The PMC is responsible for -determining who will be added as a committer. +Identifying potential new committers, calling a vote for their recognition +as a committer and processing the relevant documents are tasks to which +the whole community can contribute. -Please see the formal policy and process -[documentation for adding committers](https://www.apache.org/dev/pmc.html#committer-management). -This page discusses best practices in how to think about new committers. +Each project has a different approach to managing new committers. This page +describes a common process found in many Apache projects. It also provides +draft templates for the various communications that are necessary. -In addition to the mechanisms for adding committers, give some thought -to [practical steps you can take to attract new -contributors](/pmc/community-growth.html). +Some of the PMCs automatically make committers PMC members. The templates below +have conditional `[if]` clauses for that. + +If the PMC has separate process for approving PMC members, see +[new PMC member](/pmc/adding-pmc-members.html). +The [Contributor Ladder](https://community.apache.org/contributor-ladder.html) helps explain different roles. {{% toc %}} -## Who should be a committer? +<a name="NewCommitter-Summary"></a> +## TL;DR - Inviting a new Committer + +1. Discuss the proposed committer (and optionally PMC member). (Use + [this template](/templates/committer-discuss.txt).) +1. If the discussion seems to be going positively, + call a vote. (Use [this template](/templates/committer-vote.txt) for Review Comment: Suggest making link text detailed, not generic (which sounds like "click here" to me somehow). So: Use the [discussion template for a new committer]... ########## source/pmc/adding-committers.md: ########## @@ -58,29 +98,164 @@ can do to become a better contributor. See also [Becoming A Committer](https://community.apache.org/contributors/becomingacommitter.html) for general advice you might offer. -## Vote process +The following are some points to consider when assessing a candidate's qualifications for committership. + +<a name="NewCommitter-Abilitytoworkco-operativelywithpeers."></a> +### Ability to work cooperatively with peers. +How do we evaluate? + + - By the interactions they have through email. + - By how they respond to criticism. + - By how they participate in the group decision-making process. + +<a name="NewCommitter-Abilitytobeamentor."></a> +### Ability to be a mentor. +How do we evaluate? + + - By the interactions they have through email. + - By how clear they are and how willing they are to identify or even create appropriate background +materials. + +<a name="NewCommitter-Community"></a> +### Community +How do we evaluate? + + - By the interactions they have through email. + - Do they help to answer questions raised on the mailing list; do they show a helpful +attitude and respect for other people's ideas? + +<a name="NewCommitter-Committment"></a> +### Commitment +How do we evaluate? + + - By time already given to the project. + - By how well they stick with the process through tough issues. + - By how they help on not-so-fun tasks. + +<a name="NewCommitter-Personalskill/ability"></a> +### Personal skill/ability +How do we evaluate? + + - A solid general understanding of the project. + - Quality of discussion in email. + - Whether their patches (where applicable) are easy to apply with only a cursory review. + +<a name="NewCommitter-NewCommitterProcess"></a> +## New Committer Process + +This section describes a typical Apache project's process for handling the +vote to add a new committer. Templates mentioned in the process appear +later in this document. + +<a name="NewCommitter-Discussion"></a> +### Discussion + +We do the discussion and vote on the `private@` mailing list to enable a frank +discussion. Any PMC member may propose a potential committer or PMC +member. This is **not** the sole responsibility or right of the PMC +chair. + +You can use [this template to start the +discussion](/templates/committer-discuss.txt). + +We invite people to join as committers/PMC members, not github ids. It is +fine to refer to the candidate's github id for context, but the person should +be referred to by their name. It is not necessary to have their full legal +name (that will be kept private) but it is important to use their name, as +they refer to themselves in email. If a person is known only by their github +id, it is ok to ask them for their real name prior to holding a VOTE. + +We need to be sure that they are committed people with whom we can work. +They will be our peers. We will have already observed that they are +committed to the project and graceful toward users and other developers. + +Don't wait too long before proposing and don't be too hasty. There is a +trade-off and something about timeliness. A point is reached where it +becomes obvious that we should invite them. This encourages them and keeps +them enthusiastic. If we leave it too long, then we risk them becoming +disillusioned. + +On the `private@` list we can each say exactly what we feel about each person, +with no holds barred. Keep the discussion concise. The praise part can +be done later in public. Keep in mind, however, that if the member becomes +a PMC member later, they will have access to this discussion. + +### Vote + +If the proposed candidate seems to be received positively by a majority +of those responding, it's time to [start a vote](/templates/committer-vote.txt). + +In some projects, new committers are automatically also made PMC members. +If this is the case in your project, use [this template to start the +vote](committer-pmc-vote.txt) instead. + +Start a separate [VOTE] thread for each new person. This makes it much easier +to review the email archives. + +Let the Vote thread run for one week. + +A positive result is achieved when there are at least 3 +1 votes and no vetoes, +as per the [ASF voting process +document](https://apache.org/foundation/voting). + +### Announcing results + +After a positive result, record the result on the PMC list with a `[RESULT][VOTE]` subject +and then invite the candidate, using [this template](/templates/committer-results.txt) +for a new committer, or [this template](/templates/committer-pmc-results.txt) +for a committer and PMC member. + +We give candidates a chance to decline committership +in private. They can post a reply to the PMC mailing list. + +After we reach a decision on the `private@` list, and after the steps above, we +[announce the new committer on the `dev` list](template/committer-announce.txt) + +Alternately, use [this template](/templates/committer-pmc-announce.txt) for new +committer + PMC member. + +You can use [this template](/templates/committer-welcome.txt) to welcome +the new committer to your project community. You are, however, +encouraged to create your own version of this template, customized to +your particular project community. + +Other notes about the process are available on the main +[Apache site](https://www.apache.org/dev/pmc.html#newcommitter). + +### Committer Account Creation +Please see the [account creation instructions](https://www.apache.org/dev/pmc.html#newcommitter). + +In summary: + +If the ICLA identifies the project and a valid Apache ID, and the +`[RESULT][VOTE]` message has been posted to the PMC private list, +the account creation request is made by the +secretary or assistant secretary who files the ICLA. + +Otherwise, the new account request should be made by the +PMC Chair (or any [ASF Member](https://www.apache.org/foundation/glossary.html#Member) +if the chair is unavailable). -The complete policy and procedure around *how* to vote for a committer, -and how to add them to the relevant rosters if and when they are voted -in, is covered in the [PMC policy -document](https://www.apache.org/dev/pmc.html#committer-management). As -a PMC member, you should read and understand that document. +The PMC chair needs to use the [ASF New Account Request](https://id.apache.org/acreq/pmc-chairs/) form to +send a new account request. Members may use [ASF New Account Request](https://id.apache.org/acreq/members/) page. -## What to do when a committer is elected +Please supply the [mail archives](https://lists.apache.org/) URL as +proof of the vote results. -Once a committer has been added to the roster, be sure that they -understand how things work in your project, rather than leaving them to -figure this out on their own. +<a name="NewCommitter-EmailTemplates"></a> +## Email Templates -Point them to specific review processes that they are expected to abide -by before committing or merging a change. +The following templates are recommended ways to phrase your email +communications around inviting a new committer, to ensure that everyone +understands your intent. -Point new committers to [Infra's guide for new -committers](https://infra.apache.org/new-committers-guide.html), which -has general information for all ASF committers. +* [Committer discussion template](/templates/committer-discuss.txt) Review Comment: Like this - using consistent link text throughout will help reinforce what specific links/documents mean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@community.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
