[
https://issues.apache.org/jira/browse/COUCHDB-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543931#comment-14543931
]
ASF GitHub Bot commented on COUCHDB-2688:
-----------------------------------------
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch/pull/49
Include lager into list of extra apps when testing
Starting lager as `lager:start` is an issue since dependencies
started by lager are not included in a list of started applications
so we don't stop them after we are done with current test.
This commit uses test_util:start_applications so all deps of lager are
included into #test_context{}
COUCHDB-2688
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iilyak/couchdb-couch
2688-start-lager-from-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 670bafcb1855a8959a820f1d0f5eaa88c462f23b
Author: ILYA Khlopotov <[email protected]>
Date: 2015-05-14T15:57:42Z
Include lager into list of extra apps when testing
Starting lager as `lager:start` is an issue since dependencies
started by lager are not included in a list of started applications
so we don't stop them after we are done with current test.
This commit uses test_util:start_applications so all deps of lager are
included into #test_context{}
COUCHDB-2688
----
> Manage lager dependencies through test_util:start_apllications
> --------------------------------------------------------------
>
> Key: COUCHDB-2688
> URL: https://issues.apache.org/jira/browse/COUCHDB-2688
> Project: CouchDB
> Issue Type: Test
> Security Level: public(Regular issues)
> Reporter: ILYA
>
> Currently we start lager as
> https://github.com/apache/couchdb-couch/blob/master/src/test_util.erl#L72
> This is an issue since dependencies started by lager are not included in a
> list of started applications so we don't stop them after we are done with
> current test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
