[
https://issues.apache.org/jira/browse/COUCHDB-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558302#comment-14558302
]
ASF GitHub Bot commented on COUCHDB-1876:
-----------------------------------------
GitHub user arturmazurek opened a pull request:
https://github.com/apache/couchdb-couch/pull/53
Fix duplicated Content-Type for show/update functions
When a show/update function returned data it added a
"Content-Type: application/json" header by itself. Then
couch_httpd added some default headers (including a yet
another "application/json" one).
This diff deduplicates those headers using a set.
COUCHDB-1876
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arturmazurek/couchdb-couch
1876-fix-duplicate-content-type
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 7a75cce61f3616333883703b6e098961079d5295
Author: Artur Mazurek <[email protected]>
Date: 2015-05-25T14:19:53Z
Fix duplicated Content-Type for show/update functions
When a show/update function returned data it added a
"Content-Type: application/json" header by itself. Then
couch_httpd added some default headers (including a yet
another "application/json" one).
This diff deduplicates those headers using a set.
COUCHDB-1876
----
> Duplicate application/json in response Content-Type for show/update functions
> -----------------------------------------------------------------------------
>
> Key: COUCHDB-1876
> URL: https://issues.apache.org/jira/browse/COUCHDB-1876
> Project: CouchDB
> Issue Type: Bug
> Components: HTTP Interface
> Reporter: Alexander Shorin
> Priority: Minor
>
> Show function:
> {code}
> function(doc,req){
> return {"json": true}
> }
> {code}
> Curl command:
> {code}
> curl -v http://localhost:5984/db/_design/test/_show/json -H "Accept:
> application/json"
>
> * Adding handle: conn: 0x24d8480
> * Adding handle: send: 0
> * Adding handle: recv: 0
> * Curl_addHandleToPipeline: length: 1
> * - Conn 0 (0x24d8480) send_pipe: 1, recv_pipe: 0
> * About to connect() to localhost port 5984 (#0)
> * Trying 127.0.0.1...
> * Connected to localhost (127.0.0.1) port 5984 (#0)
> > GET /db/_design/test/_show/json HTTP/1.1
> > User-Agent: curl/7.31.0
> > Host: localhost:5984
> > Accept: application/json
> >
> < HTTP/1.1 200 OK
> < Vary: Accept
> * Server CouchDB/1.4.0+build.c843cef (Erlang OTP/R16B) is not blacklisted
> < Server: CouchDB/1.4.0+build.c843cef (Erlang OTP/R16B)
> < Etag: "AW5C2CXR0TS88IZ5N8ZIY995B"
> < Date: Wed, 21 Aug 2013 16:06:00 GMT
> < Content-Type: application/json, application/json
> < Content-Length: 7
> < Cache-Control: must-revalidate
> <
> "true"
> * Connection #0 to host localhost left intact
> {code}
> Note line in response with: {code}Content-Type: application/json,
> application/json{code}
> While it's ok for HTTP, I believe there should be only one "application/json"
> MIME type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
