Github user kxepal commented on a diff in the pull request:

    https://github.com/apache/couchdb-config/pull/4#discussion_r32767285
  
    --- Diff: src/config.erl ---
    @@ -208,7 +208,7 @@ handle_call(all, _From, Config) ->
         {reply, Resp, Config};
     handle_call({set, Sec, Key, Val, Persist, Reason}, _From, Config) ->
         true = ets:insert(?MODULE, {{Sec, Key}, Val}),
    -    couch_log:notice("~p: [~s] ~s set to ~s for reason ~p",
    +    error_logger:info_msg("~p: [~s] ~s set to ~s for reason ~p",
    --- End diff --
    
    That's a horrible mistake. couch_log is based on lager and all logging 
routines goes through it. error_logger on other hand may become bottleneck. 
There is no practical reason to for such change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to