Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/57#issuecomment-113901460
@robertkowalski
> the problem is the formatting in lager, which is slow
Shouldn't we propose fix for lager instead? Optimizing one log call in one
popular place is good, but is that the only place we have? So far, your
benchmark covered only tiny part of CouchDB usage.
> I don't see many people working on a new log format and given that the
tickets are around 4 years old
Because they didn't have such opportunity for all these 4 years, because
they all being waited for better logging system that supports this feature?
> I am implementing for my needs now, not the ones I might have in the
future
Not sure how introducing one special optimization for one single case which
cuts every 100ms down to 96ms may be useful. But for sure, first person that
will have to touch formatting will be very upset by such special cases.
Suggestion: let's not rush now with optimizations. Let's first make solid
reproduceable benchmark suite that covers at least all the basic CouchDB usage
and then think about performance improvements. Without tracking performance in
time such optimizations makes no sense and only harms: show arbitrary developer
your changes and first his intention will be to replace it with couch_log,
because DRY and Single responsibility principle are broken here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
