GitHub user eiri opened a pull request:

    https://github.com/apache/couchdb-couch/pull/61

    Remove compression's optimization

    When a file compression set to snappy, couch is doing an additional
    optimization step by also compressing the term with deflate,
    comparing the sizes of the result binary and choosing the smaller one.
    This leads to a situation when for snappy compresed database the
    'winning' deflate compressed term got decompressed and compressed
    back into deflate on each document's write.
    
    This patch removes this compression's optimization.
    
    [Basic test](http://nbviewer.ipython.org/gist/eiri/79d91a797af9c6a6ff6d)
    demonstrate that the gained with it disk space is not significant
    enough to justify empty CPU cycles.
    
    This closes COUCHDB-2726

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eiri/couchdb-couch 
remove-compressor-optimization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit 5b7a0581a772ec3108bac8417216533706a69529
Author: Eric Avdey <[email protected]>
Date:   2015-06-24T14:50:39Z

    Remove compression's optimization
    
    When a file compression set to snappy, couch is doing an additional
    optimization step by also compressing the term with deflate,
    comparing the sizes of the result binary and choosing the smaller one.
    This leads to a situation when for snappy compresed database the
    'winning' deflate compressed term got decompressed and compressed
    back into deflate on each document's write.
    
    This patch removes this compression's optimization.
    [Basic test](http://nbviewer.ipython.org/gist/eiri/79d91a797af9c6a6ff6d)
    demonstrate that the gained with it disk space is not significant
    enough to justify empty CPU cycles.
    
    This closes COUCHDB-2726

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to