Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-nmo/pull/2#discussion_r38744097
--- Diff: test/isonline.js ---
@@ -138,9 +160,10 @@ lab.experiment('isonline', () => {
assert.ok(/online/.test(args[1]), 'returns online for online
nodes');
done();
};
- nmo.load({nmoconf: __dirname + '/fixtures/randomini'})
+ nmo.load({nmoconf: __dirname + '/fixtures/randomini', json: false})
.then(() => {
cli(common.NODE);
+ done();
--- End diff --
with the done()added there this async tests ends too early. if you take a
look at the block above, line 159 - where i monkey patch console.log to verify
that we are logging the result to the console and then call done - that is the
asserting part of the test
i think that is the reason why test coverage went down
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
