Github user nickva commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/28#issuecomment-141611612
I refactored code as suggested.
1. Now have 30 some tests that should cover most validation code paths.
2. Added validation of shows, lists, updates, filters functions. Special
cases for views.lib (looks like a view but it is not one), and options (not a
mapping of name : contents, so I let it take any values for now).
3. I tried to refactor validate_* function to re-use as much as possible.
They ended up being per-type (validate_object, validate_array, validate_string).
4. Spaces after commas.
Kxepal, janl, eiri thanks for feedback and for help in #couchdb-dev.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
