[
https://issues.apache.org/jira/browse/COUCHDB-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901194#comment-14901194
]
ASF subversion and git services commented on COUCHDB-2818:
----------------------------------------------------------
Commit 7691f48627ebac932f41e0ac2d7748e979673883 in couchdb-couch-mrview's
branch refs/heads/master from [~kzx]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb-couch-mrview.git;h=7691f48 ]
Improve design document validation
Jira: COUCHDB-2818
Validates top level values:
- These should be object: "options", "filters", "lists",
"shows", "updates", "views"
- "rewrites" is an array
- "language" and "validate_doc_update" are strings
Values in "filters", "lists", "shows", "updates" should be strings.
They are mappings from function names to function contents.
Values in "options" can be anything (currently there are 2 boolean
options, but they are not checked specifically).
Views are special:
- "lib" is special: its value will be an object that
contains mapping to different libraries. The contents of
that object is not validated.
- If any other object has "map" or "reduce" value, it should
be a string.
Also try to produce helpful messages for user so they know where
the problem is.
Some examples of responses:
```
$ http -phb PUT $DB1/db2/_design/des1 views:='{"v1":"nope"}'
HTTP/1.1 400 Bad Request
{
"error": "invalid_design_doc", "reason": "View v1 must be an object"
}
$ http -phb PUT $DB1/db2/_design/des1 lists:='{"l1":true}'
HTTP/1.1 400 Bad Request
{
"error": "invalid_design_doc", "reason": "`l1` in lists is not a string"
}
$ http -phb PUT $DB1/db2/_design/des1 views:='{"v1": {"map":1}}'
HTTP/1.1 400 Bad Request
{
"error": "invalid_design_doc", "reason": "`map` in v1 must be a string"
}
```
> Design documents accept invalid views
> -------------------------------------
>
> Key: COUCHDB-2818
> URL: https://issues.apache.org/jira/browse/COUCHDB-2818
> Project: CouchDB
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: Database Core, Documentation, JavaScript View Server
> Reporter: Nick Vatamaniuc
>
> Design documents seem to accept invalid views.
> For example:
> {code}
> $ http PUT $DB1/db2/_design/des1 views:='{ "v1" :
> "function(d){emit(d._id,d);}" }'
> HTTP/1.1 201 Created
> {
> "id": "_design/des1",
> "ok": true,
> "rev": "1-04701f13eb827265c442d219bd995e91"
> }
> {code}
> Going by the documentation for design documents:
> http://docs.couchdb.org/en/latest/api/ddoc/common.html#put--db-_design-ddoc ,
> a view should be an object that has a map (a string) and an optional reduce
> (string).
> Interestingly some validation is performed to check that views field itself
> is an object. For example:
> {code}
> $ http PUT $DB1/db2/_design/des1 views:='"x"'
> HTTP/1.1 400 Bad Request
> {
> "error": "invalid_design_doc",
> "reason": "`views` parameter must be an object."
> }
> {code}
> Also there is a deeper level validation of map functions:
> {code}
> $ http PUT $DB1/db2/_design/des1 views:='{ "m":{"map":""} }'
> {
> "error": "not_found",
> "reason": "missing function"
> }
> {code}
> If there is interest, I have a patch that, if provided: views, filters,
> lists, show, updates, options are objects. rewrites are arrays,
> validate_doc_update and language are strings.
> Then if views is provided, each view is an object. It must have a map
> function (a string) and an optional reduce function (also a string).
> Here is an example how it works:
> {code}
> $ http PUT $DB1/db2/_design/des1 views:='{ "m":"bad" }'
> HTTP/1.1 400 Bad Request
> {
> "error": "invalid_design_doc",
> "reason": "View m must be an object"
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
