Github user davisp commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/107#discussion_r40967252
--- Diff: src/couch_query_servers.erl ---
@@ -296,7 +296,8 @@ filter_docs(Req, Db, DDoc, FName, Docs) ->
#httpd{} = HttpReq ->
couch_httpd_external:json_req_obj(HttpReq, Db)
end,
- JsonDocs = [couch_doc:to_json_obj(Doc, [revs]) || Doc <- Docs],
+ Limit = config:get_integer("query_server_config", "filter_revs_limit",
20),
--- End diff --
Nope.
On Thu, Oct 1, 2015 at 2:50 PM, Russell Branca <[email protected]>
wrote:
> In src/couch_query_servers.erl
> <https://github.com/apache/couchdb-couch/pull/107#discussion_r40957982>:
>
> > @@ -296,7 +296,8 @@ filter_docs(Req, Db, DDoc, FName, Docs) ->
> > #httpd{} = HttpReq ->
> > couch_httpd_external:json_req_obj(HttpReq, Db)
> > end,
> > - JsonDocs = [couch_doc:to_json_obj(Doc, [revs]) || Doc <- Docs],
> > + Limit = config:get_integer("query_server_config",
"filter_revs_limit", 20),
>
> @kxepal <https://github.com/kxepal> I looked at all the places that call
> couch_query_server:json_doc/1 and I think you're right, that would be a
> good safe option to making the revs_limit logic work here for show,
> filter, and update functions. Any objections @davisp
> <https://github.com/davisp> @rnewson <https://github.com/rnewson>?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/couchdb-couch/pull/107/files#r40957982>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
