GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/551

    Fix for logout link showing up twice in footer

    An old bug is the Logout link in the footer showing up twice. It's
    a little difficult to reproduce consistently, but I've found this
    works the best (Mac, chrome):
    1. open dev tools (it slows down browser performance),
    2. Login to Fauxton, notice the single "logout" link in footer.
    3. click on the browser URL bar and click <enter>
    4. Repeat the above until you see two "logout" links in the footer.
    
    What's happening is that when you see two logout links, 
    the change event on Auth.session is firing twice, each of which 
    adds a new footer link.
    
    This fix just ensures the link is removed prior to adding it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton duplicate-logout-link

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #551
    
----
commit 5f5eed38bcb8a5c042fba1e092898a8055e09977
Author: Ben Keen <[email protected]>
Date:   2015-10-07T03:36:44Z

    Fix for logout link showing up twice in footer
    
    An old bug is the Logout link in the footer showing up twice. It's
    a little difficult to reproduce consistently, but I've found this
    works the best (Mac, chrome):
    1. open dev tools
    2. Login to Fauxton, notice the single "logout" link in footer.
    3. click on the browser URL bar and click <enter>
    4. Repeat the above until you see two "logout" links in the footer.
    
    What's happening is the change event on Auth.session is firing
    twice, each of which adds a new footer link. Seems like with
    some page loads it only fires once, sometimes twice.
    
    This ensures the link is removed prior to adding it.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to