Github user chewbranca commented on the pull request:
https://github.com/apache/couchdb-couch/commit/0c6ff065f024aea941b96a95e6b9b3e75b10856e#commitcomment-13668406
In src/couch_lru.erl:
In src/couch_lru.erl on line 76:
I don't think it's a good idea to call back into `couch_server` from
`couch_lru` for two reasons: 1) currently `couch_lru` is self contained and a
general purpose LRU, adding this would break that; 2) while I see your
`couch_server:close/1` function currently does a cast to the `couch_server`
pid, if that was every changed to do a call, something entirely reasonable if
you wanted to limit the rate at which calls to close happen, then that change
would result in couch_server deadlocking on itself as the sweep_lru handle_cast
logic calls couch_lru which would then do a call back into itself and get stuck.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
