Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-mem3/pull/16#discussion_r41782927
--- Diff: src/mem3_httpd.erl ---
@@ -44,7 +46,12 @@ handle_shards_req(#httpd{method='GET',
couch_httpd:send_json(Req, {[
{range, Shard},
{nodes, Dbs}
- ]}).
+ ]});
+handle_shards_req(#httpd{path_parts=[_DbName, <<"_shards">>]}=Req, _Db) ->
+ chttpd:send_method_not_allowed(Req, "GET");
+handle_shards_req(#httpd{path_parts=[_DbName, <<"_shards">>, _DocId]}=Req,
_Db) ->
--- End diff --
Yeah, I understood your reason for two clauses. I guess it's worth the
duplication, though until we move to cowboy we're not sending the right errors
in many other cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
