Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/543#issuecomment-149239824
  
    This looks SWEET. Really, really excited by this ticket.
    
    UI remarks (for Dante?):
    - I find "View" as the default text for the different views a little 
unclear until I click on it. We shied away from just having the three icons in 
a row? (each with a tooltips, say?) 
    - maybe a pale grey line to the right of View, just to make it like the 
other header btns? 
    - might be nice to change up the icon in the header based on the selected 
View rather than just having the eye icon all the time. 
    - the clickable link locations to take you to the full page doc editor 
differ depending on whether you're on the all docs or a View. All docs has _id 
in the first column; Views have the last. Any chance that could be consistent? 
I'd favour the first column.
    - the greys are a little weak for the bulk selector, in context of Fauxton. 
See: 
    <img width="1418" alt="screen shot 2015-10-19 at 7 55 24 am" 
src="https://cloud.githubusercontent.com/assets/512116/10581315/da3c173e-7636-11e5-9d33-aad7ac797047.png";>
    
    Super small issues:
    - the down arrow on the bulk selector widget should show a cursor:pointer 
to indicate clickable. The clickable area should be the full square behind it, 
too. 
    - when you click from page to page, the bulk selector widget noticeably 
checks then unchecks. A bit unsightly. 
    - the garbage can icon in the bulk selector that appears is perhaps 1 or 
2px left of centre.
    - the "View" header button shouldn't have a 1px border left: it appears a 
little too thick (see screenshot above)
    
    Other:
    - selecting all rows that can be deleted doesn't check them all. How come? 
I'm on a default _all_docs with default query options. Seems curious you can't 
delete them all. 
    - could we put the View selection (expanded, table, collapsed) into local 
storage? I think that a lot of people are going to want table view to be the 
default & won't want to have to re-select it after each page refresh. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to