GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/562
Clipboard component updates
This makes two changes to the <Clipboard /> component:
- fixes it to work properly on Safari and FF
- adds a callback for use by parent components
See individual commit messages for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton
clipboard-component-updates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/562.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #562
----
commit 8e68a61a2806383b29a6ad3815d7794cd6f61972
Author: Ben Keen <[email protected]>
Date: 2015-10-20T21:47:37Z
Fix issue where clipboard not copying for FF or Safari
Turns out that the <Clipboard /> component wasn't actually copying
anything to the clipboard for FF or Safari due to the DOM element
not having a unique ID. This adds one.
No test because our version of zeroclipboard (1.3.5) doesn't expose
a getData() method so we can't tell if a click actually adds something
to its memory. If/when we upgrade to 2.x we can add a test. Also,
Flash-based script like this isn't available for testing environ.
commit bf2b1d788ce8d4699d19669c181318d39d655d8e
Author: Ben Keen <[email protected]>
Date: 2015-10-20T22:17:10Z
Add callback to Clipboard component
This just adds a callback to the <Clipboard /> component that
gets called once the copy to clipboard action is completed.
Again, this is not testable due to Flash not being available
on the testing environment.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
