Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-couch/pull/125#issuecomment-154158219
@iilyak, I agree with your last comment, as it seems a bit strange to save
the plugin state while tests are running.
@kxepal, the reason check_is_admin_no_match was failing downstream was
because -- in addition to loading the couch_db_pluging_tests plugin that was
meant to handle that case -- all the couch_epi plugins specified in Cloudant's
couch_epi.config were being loaded, and one of them was inadvertently handling
(and breaking) the test case. I think any time a unit test pulls in
configuration data that it doesn't completely specify, we run the risk of it
breaking something downstream. I could certainly create another plugin that
simulates what was happening, but I don't think it will really help prevent
this sort of thing in the future. By loading *only* the plugins we want to
test, we force test behavior downstream to be the same. Does that make sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
