[
https://issues.apache.org/jira/browse/COUCHDB-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992956#comment-14992956
]
ASF GitHub Bot commented on COUCHDB-2872:
-----------------------------------------
GitHub user jaydoane opened a pull request:
https://github.com/apache/couchdb-couch/pull/126
Remove lager and goldrush from default list of apps started by
test_util:start_couch/2
Also, create a common list of default apps that is started and stopped
consistently
COUCHDB-2872
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch
2872-cleanup-start_couch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit 94088aded2c84c75d95723950d4cc5ed154758d6
Author: Jay Doane <[email protected]>
Date: 2015-11-06T02:13:30Z
Remove lager and goldrush from default list of apps started by
test_util:start_couch/2
Also, create a common list of default apps that is started and stopped
consistently
COUCHDB-2872
----
> Don't start unnecessary applications from test_util:start_couch/2
> -----------------------------------------------------------------
>
> Key: COUCHDB-2872
> URL: https://issues.apache.org/jira/browse/COUCHDB-2872
> Project: CouchDB
> Issue Type: Improvement
> Components: Test Suite
> Reporter: Jay Doane
>
> Currently, both lager and goldrush are being started by default, but the
> tests will run without explicitly starting them. Removing them also makes it
> possible to use this code downstream, where lager is not necessarily a
> dependency.
> https://github.com/apache/couchdb-couch/blob/master/src/test_util.erl#L73
> Finally, the same applications which are started by default should also be
> stopped by default. Currently, those are different lists of applications.
> https://github.com/apache/couchdb-couch/blob/master/src/test_util.erl#L79
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
