[
https://issues.apache.org/jira/browse/COUCHDB-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011658#comment-15011658
]
ASF GitHub Bot commented on COUCHDB-2874:
-----------------------------------------
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/36
Rewrite via query server
COUCHDB-2874
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-couch-mrview 2874-rewrite-func
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-mrview/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 946d942a481c7bae8b1f8045a8909bf921a20e3a
Author: Alexander Shorin <[email protected]>
Date: 2015-11-10T17:44:25Z
Rewrite ddoc validation routines
While it solve the own problem well, it contains few design issues that
makes unable to keep it for further updates:
1. It's type-centric validation. However, our ddocs have quite complex
structure and validation logic, so it eventually have to write special
clause for most of the validated fields turning it into field-centric.
2. It mixes logic of type checking and relation checking.
Here we turn it into rule based validation where each rule is a path of
field-type pairs while all relation checks are moved into own functions.
Moreover, we can now exactly say the path for the field that caused
issues.
commit 6c9833d667e319b82a7a1fffb8ba92116534e63f
Author: Alexander Shorin <[email protected]>
Date: 2015-11-10T17:55:02Z
Accept rewrites as string function
COUCHDB-2874
----
> Allow rewrites to be JS function
> --------------------------------
>
> Key: COUCHDB-2874
> URL: https://issues.apache.org/jira/browse/COUCHDB-2874
> Project: CouchDB
> Issue Type: Improvement
> Components: HTTP Interface, JavaScript View Server, View Server
> Support
> Reporter: Alexander Shorin
>
> https://pony-poc.apache.org/thread.html/dad51d6ee949d10e979a18654f36d32d9ac6f1bf03df67588f5124d8@1443391867@%3Cdev.couchdb.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)