Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/82#discussion_r48728241
--- Diff: src/chttpd_db.erl ---
@@ -407,7 +407,16 @@
db_req(#httpd{method='POST',path_parts=[_,<<"_bulk_docs">>], user_ctx=Ctx}=Req,
true -> [all_or_nothing|Options];
_ -> Options
end,
- case fabric:update_docs(Db, Docs, Options2) of
+ case fabric_att_handler:external_store() of
+ true ->
+ couch_log:debug("store attachment externaly", []),
+ NewDocs = fabric_att_handler:att_store(Db,
+
fabric:docs(Docs));
+ false ->
+ couch_log:debug("externalize attachment: disabled",[]),
+ NewDocs = Docs
+ end,
--- End diff --
hm, and really, it should be `fabric:update_docs` itself that makes this
decision, the http presentation layer should not know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
