Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/598#issuecomment-169751605
True, this chunk of code isn't being used, but I disagree it's useless. We
always override it, true, but it looks like we don't need to for Fauxton, no?
(i.e. we could rely on the development or production defaults to take care of
providing those default values). But besides that, I kind of like being able to
see at a glance exactly what info grunt it looking for to create the build.
Instead, in addition to dropping the code like you've done, could we add a
validation check to ensure the required params are there: src, dest, and the
required vars? That could output a nice juicy "such and such is missing" error
to ensure grunt gets what it wants. I realize this isn't strictly needed now,
but for people editing / creating new settings files it may be helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
