Github user nickva commented on the pull request:
https://github.com/apache/couchdb-config/pull/7#issuecomment-175380774
I checked this one against master using this patch
```
-{config, "config",
"84197a6f1c5cb43447239df1fe57b4312b0c03c4"},
+%{config, "config",
"84197a6f1c5cb43447239df1fe57b4312b0c03c4"},
+{config, {url, "https://github.com/cloudant/couchdb-config.git"},
+ {branch, "55507-config_tests-remove-lager"}
+},
```
Tested on Mac OS X, Erlang 18.2
Diff-ed output of `make eunit` with that without the patch and couldn't see
any significant differences (test deltas, proc ids, some compilation order was
different but nothing stood out).
So +1 from me, though @jaydoane might be better to squash the commits into
one commit?
@kxepal what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
