Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/630#discussion_r50954660
  
    --- Diff: assets/less/icons.less ---
    @@ -18,21 +18,23 @@
     /* had to add a custom template to the generator to get this to compile to 
append the proper path and specify  "url" instead of "font-url":
     
https://github.com/seanbarclay/fontcustom/blob/1c3ad3d2633d3a8add39e8827115394e9ec02d88/lib/fontcustom/generator/template.rb
     */
    +@fauxtonFont: "fauxtonicon1";
    +
     @font-face {
    -  font-family: "fauxtonicon";
    -  src: url("../fonts/fauxtonicon.eot");
    -  src: url("../fonts/fauxtonicon.eot?#iefix") format("embedded-opentype"),
    -       url("../fonts/fauxtonicon.woff") format("woff"),
    -       url("../fonts/fauxtonicon.ttf") format("truetype"),
    -       url("../fonts/fauxtonicon.svg#fauxtonicon") format("svg");
    +  font-family: "fauxtonicon1";
    +  src: url("../fonts/fauxtonicon1.eot");
    +  src: url("../fonts/fauxtonicon1.eot?#iefix") format("embedded-opentype"),
    +       url("../fonts/fauxtonicon1.woff") format("woff"),
    +       url("../fonts/fauxtonicon1.ttf") format("truetype"),
    +       url("../fonts/fauxtonicon1.svg#fauxtonicon1") format("svg");
    --- End diff --
    
    what do you think of putting the font-name into a variable, so it just has 
to get changed once?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to