Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/100#discussion_r51142280
--- Diff: src/chttpd_cors.erl ---
@@ -176,15 +180,15 @@ headers(Req, RequestHeaders, Origin, Config) ->
true ->
AcceptedOrigins = get_accepted_origins(Req, Config),
CorsHeaders = handle_headers(Config, Origin, AcceptedOrigins),
- maybe_apply_headers(CorsHeaders, RequestHeaders);
+ maybe_apply_headers(Config, CorsHeaders, RequestHeaders);
--- End diff --
Personally I'd get `exposed_headers` out of config on a line above to make
input parameters in `maybe_apply_headers` consistent to be all headers, but
this is a question of a personal taste, so feel free to ignore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
