GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/642
trays: use higher order components to connect them to stores
this is the first step to get rid of `<Tray />` which uses
`FauxtonAPI.Events` and additionally manages its own state by
accessing the DOM which leads to subtle bugs.
we use composition/higher order components as all trays share the
same wrapper, but have different stores connected.
- change test urls to example.com, which is reserved for testing
- use React.findDOMNode
- trays don't touch the DOM directly any more
COUCHDB-2943
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton
trays-composition
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/642.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #642
----
commit 7200dce0418ba71dbac08263c2691b7a40ce2726
Author: Robert Kowalski <[email protected]>
Date: 2016-02-09T17:39:55Z
trays: use higher order components to connect them to stores
this is the first step to get rid of <Tray /> which uses
`FauxtonAPI.Events` and additionally manages its own state by
accessing the DOM which leads to subtle bugs.
we use composition/higher order components as all trays share the
same wrapper, but have different stores connected.
- change test urls to example.com, which is reserved for testing
- use React.findDOMNode
- trays don't touch the DOM directly any more
COUCHDB-2943
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
