Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/643#discussion_r52396080
  
    --- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
    @@ -173,8 +173,8 @@ function (app, FauxtonAPI, React, ReactDOM, Stores, 
Actions, Components) {
             <div className="query-group" id="query-options-key-search">
               <div className="add-on">Keys</div>
               <div className="btn-group toggle-btns row-fluid">
    -            <label id="byKeys" onClick={this.toggleByKeys} 
className={byKeysButtonClass}>By Key(s)</label>
    -            <label id="betweenKeys" onClick={this.toggleBetweenKeys} 
className={betweenKeysButtonClass}>Between Keys</label>
    +            <label style={{width: '101px'}} id="byKeys" 
onClick={this.toggleByKeys} className={byKeysButtonClass}>By Key(s)</label>
    +            <label style={{width: '101px'}} id="betweenKeys" 
onClick={this.toggleBetweenKeys} className={betweenKeysButtonClass}>Between 
Keys</label>
    --- End diff --
    
    However, there are a lot of other styles particular to this component that 
aren't inline. For consistency, if they're in both places I'd prefer keeping it 
in just the one. Just my preference - I don't object to this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to