Github user eiri commented on a diff in the pull request:

    https://github.com/apache/couchdb-chttpd/pull/101#discussion_r53011410
  
    --- Diff: src/chttpd_cors.erl ---
    @@ -360,7 +399,7 @@ get_origin(Req) ->
             undefined ->
                 undefined;
             Origin ->
    -            ?l2b(to_lower(Origin))
    +            ?l2b(Origin)
    --- End diff --
    
    Actually CORS specs 
[point](https://www.w3.org/TR/cors/#origin-request-header) to "The Web Origin 
Concept" RFC and hence require host to be ["converted to lowercase using the 
ascii-casemap collation"](https://tools.ietf.org/html/rfc6454#section-4) 
(subsection 5). So I guess we still need to_lower here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to