Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/101#discussion_r53064076
--- Diff: src/chttpd_cors.erl ---
@@ -306,6 +316,35 @@ get_cors_config(#httpd{cors_config = undefined}) ->
get_cors_config(#httpd{cors_config = Config}) ->
Config.
+cors_config(Host, Key, Default) ->
+ config:get(cors_section(Host), Key,
+ config:get("cors", Key, Default)).
+
+cors_section(Host0) ->
+ {Host, _Port} = split_host_port(Host0),
--- End diff --
The function would work, the config wouldn't. In real life value for header
`Host` set to [target's
host](https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.23), not
URI, so cors config would be expected to be under `[cors:partner.com]` where
partner.com is the name of our vhost and `http://restricted.dev:8000`is the
address of the server that hosts javascript that does ajax call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
