Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/650#discussion_r53666391
--- Diff: app/addons/documents/index-editor/components.react.jsx ---
@@ -326,10 +351,12 @@ function (app, FauxtonAPI, React, Stores, Actions,
Components, ReactComponents)
return;
}
+ var doc = this.refs.designDocSelector.getDesignDoc();
--- End diff --
hmmm, not feeling comfortable by calling a getter on a view to get data. we
used to do that with backbone a lot and it got us really into trouble.
maybe we can put that into a store and let the component fire an action?
the dumb component does not need to be connected directly to the store, it
could get the data updates as props from the parent component
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
