Github user eiri commented on the pull request:

    
https://github.com/apache/couchdb-couch-replicator/pull/26#issuecomment-188482611
  
    @chewbranca I agree that using ddoc cache is a good thing, not so much on 
calling fabric from couch, looks like an opportunity to fall into cycling 
calls. I'd prefer either have ddoc cache to support none clustered databases or 
change the replicator (and its tests) to be cluster aware. 
    
    Anyway, I've got the tests passing locally with inserting the test's ddoc 
into ddoc_cache in `couch_replicator_filtered_tests` and adding the following 
clause in `couch_changes.erl`
    
    ```
    filter(Db, DocInfo, {fetch, Style, Req, {DesignId, _}, FName}) ->
        {ok, DDoc} = ddoc_cache:open_doc(fabric:dbname(Db), DesignId),
        filter(Db, DocInfo, {custom, Style, Req, DDoc, FName}).
    ```
    
    This looks rather hacky, so if you have a better solution I'm all ears.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to