Github user iilyak commented on a diff in the pull request:
https://github.com/apache/couchdb-mem3/pull/17#discussion_r54027417
--- Diff: src/mem3.erl ---
@@ -254,6 +254,11 @@ allowed_nodes() ->
nodes_in_zone(Nodes, Zone) ->
[Node || Node <- Nodes, Zone == mem3:node_info(Node, <<"zone">>)].
+non_maintenance_nodes() ->
+ Nodes = [node() | erlang:nodes()],
+ {Modes, _} = rpc:multicall(config, get, ["couchdb",
"maintenance_mode"]),
--- End diff --
@tonysun83: Let's assume you send requests to nodes in increasing order
`node1, node2, node3`. But one of them delayed and you get responses in
following order `resp_node1, resp_node3, resp_node2`. When you do lists:zip you
would get `[{node1, resp_node1}, {node2, resp_node3}, {node3, resp_node2}]`.
When you latter filter by mode you would filter out (or keep) the wrong ones.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
