[
https://issues.apache.org/jira/browse/COUCHDB-2956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182178#comment-15182178
]
ASF GitHub Bot commented on COUCHDB-2956:
-----------------------------------------
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb/pull/388
Fix favicon caching on leap year
COUCHDB-2956
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb 2956-fix-cache-on-leap-year
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/388.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #388
----
commit 9f1001834e2462606f4648bef3d2df2f4af3ca15
Author: Alexander Shorin <[email protected]>
Date: 2016-03-06T14:24:56Z
Fix favicon caching on leap year
COUCHDB-2956
----
> favicon produces a stack trace on February the 29th.
> ----------------------------------------------------
>
> Key: COUCHDB-2956
> URL: https://issues.apache.org/jira/browse/COUCHDB-2956
> Project: CouchDB
> Issue Type: Bug
> Components: HTTP Interface
> Affects Versions: 1.6.1
> Reporter: Matthew Buckett
>
> I was just running my couch instance today and whenever I request the
> favicon (/favicon.ico) I get this in my logs:
> {code}
> couchdb_1 | [error] [<0.20390.0>] Uncaught error in HTTP request:
> {error,if_clause}
> couchdb_1 | [info] [<0.20390.0>]
> Stacktrace:[{calendar,date_to_gregorian_days,3,
> couchdb_1 |[{file,"calendar.erl"},{line,116}]},
> couchdb_1 | {calendar,day_of_the_week,3,
> couchdb_1 |[{file,"calendar.erl"},{line,151}]},
> couchdb_1 | {couch_util,rfc1123_date,1,
> couchdb_1 |[{file,"couch_util.erl"},{line,462}]},
> couchdb_1 | {couch_httpd_misc_handlers,
> couchdb_1 | handle_favicon_req,2,
> couchdb_1 |[{file,"couch_httpd_misc_handlers.erl"},
> couchdb_1 | {line,53}]},
> couchdb_1 |
> {couch_httpd,handle_request_int,5,
> couchdb_1 |[{file,"couch_httpd.erl"},{line,318}]},
> couchdb_1 | {mochiweb_http,headers,5,
> couchdb_1 |[{file,"mochiweb_http.erl"},{line,94}]},
> couchdb_1 | {proc_lib,init_p_do_apply,3,
> couchdb_1 |[{file,"proc_lib.erl"},{line,239}]}]
> couchdb_1 | [info] [<0.20390.0>] 192.168.99.1 - - GET /favicon.ico 500
> couchdb_1 | [error] [<0.20390.0>] httpd 500 error response:
> couchdb_1 | {"error":"unknown_error","reason":"if_clause"}
> {code}
> The last part of the couch code is:
> {code}
> rfc1123_date(UniversalTime) ->
> {{YYYY,MM,DD},{Hour,Min,Sec}} = UniversalTime,
> DayNumber = calendar:day_of_the_week({YYYY,MM,DD}),
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
