Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/651#discussion_r55554632
--- Diff: app/addons/documents/routes-index-editor.js ---
@@ -28,40 +28,53 @@ define([
'addons/documents/pagination/pagination.react',
'addons/documents/header/header.react',
'addons/documents/header/header.actions',
+ 'addons/documents/sidebar/actions'
],
function (app, FauxtonAPI, Helpers, BaseRoute, Documents,
IndexEditorComponents, ActionsIndexEditor,
Databases, Components, IndexResultsStores, IndexResultsActions,
- IndexResultsComponents, ReactPagination, ReactHeader,
ReactHeaderActions) {
+ IndexResultsComponents, ReactPagination, ReactHeader,
ReactHeaderActions, SidebarActions) {
var IndexEditorAndResults = BaseRoute.extend({
- layout: 'two_pane',
+ layout: 'with_tabs_sidebar',
routes: {
- 'database/:database/new_view': 'newViewEditor',
- 'database/:database/new_view/:designDoc': 'newViewEditor',
+ 'database/:database/new_view': {
+ route: 'createView',
+ roles: ['fx_loggedIn']
+ },
+ 'database/:database/new_view/:designDoc': {
+ route: 'createView',
+ roles: ['fx_loggedIn']
+ },
'database/:database/_design/:ddoc/_view/:view': {
- route: 'viewFn',
+ route: 'showView',
+ roles: ['fx_loggedIn']
+ },
+ 'database/:database/_design/:ddoc/_view/:view/edit': {
--- End diff --
Hmm, good point. How do you suggest handling this? The edit page are
separate. I guess I can keep the same URL for both, and just handle routing
exclusively in the JS... but having a way to link directly to it through a URL
string alone is kinda convenient. (Query string param...? Seems klutzy).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
