Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/161#issuecomment-209616524
@rnewson View compaction files handled in `couch_file:deleted/3` function
which does what the first PR comment describes and you are commenting on
`couch_file:delete_dir/2` which is called on database's views directories when
database deleted while parameter `rename_on_delete` set to false
[[ref]](https://github.com/cloudant/couchdb-couch/blob/61028-fix-rename-on-delete/src/couch_file.erl#L258)
The scope of PR is to extend exiting `rename_on_delete` behaviour on
compaction and view files. I'm doing this by making views directories to be
renamed on deletion of a database in the same manner the database file renamed
right now. For compaction files I'm making them not to be deleted in `.deleted`
directory after renaming, the same way as Cloudant does. I'm renaming them
differently, though, so they'd be more easily identified if necessary.
The renaming configuration parameters or radically diverging from how file
preservation works right now is not in scope of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
