Github user mikewallace1979 commented on the pull request:
https://github.com/apache/couchdb-mem3/pull/19#issuecomment-209911468
This looks like a good set of changes to me though I'm dubious whether I am
qualified to give a +1 here.
My only comments concern 5bf9317f51eb60976b6f371c3313213782efe54b:
- It might be helpful to have some module-level comments that give a few
pointers to the reader on the underlying implementation.
- The mechanism for ensuring all bucketed shards are pushed in the event of
no further updates might not be obvious to all future maintainers. It
might
be worth explicitly noting that the gen_server timeout is being set by
the
return value of the callbacks (via maybe_push_shards/1) and that the
timeout
will trigger the handle_info(timeout, St) clause.
- I can't see how the delay is actually used other than when rebucketing
the shards in response to a config change.
It also feels like these new config parameters should be documented
somewhere
though I'm not exactly sure where that should be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
