Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/681#discussion_r59899307
--- Diff: app/addons/documents/changes/components.react.jsx ---
@@ -351,6 +360,18 @@ define([
};
},
+ onClipboardClick: function (target) {
+ var msg = 'The document ID has been copied to your clipboard.';
--- End diff --
True, there's lot of instances where let will be better. Just wondering
what you mean here though: wouldn't they be the same in this usage? I need msg
to be defined in the function block to allow overriding. If I needed the var
only in the `if` I could define it as a `let`, but I don't.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---