[ 
https://issues.apache.org/jira/browse/COUCHDB-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247192#comment-15247192
 ] 

ASF GitHub Bot commented on COUCHDB-2834:
-----------------------------------------

GitHub user nickva opened a pull request:

    https://github.com/apache/couchdb-couch/pull/164

    When reading attachments, avoid closing connections too early

    Signal mochiweb to not send connection:close headers
    in order for the socket to be reused.
    
    Before this commit, this signaling was done too late.
    
    COUCHDB-2834

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch couchdb-2834

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch/pull/164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #164
    
----
commit c4624d95e45ec4b45f7c6ddfbc4cd61413ee1d63
Author: Nick Vatamaniuc <[email protected]>
Date:   2016-04-19T04:59:30Z

    When reading attachments, avoid closing connections too early
    
    Signal mochiweb to not send connection:close headers
    in order for the socket to be reused.
    
    Before this commit, this signaling was done too late.
    
    COUCHDB-2834

----


> Server sends connection: close too early
> ----------------------------------------
>
>                 Key: COUCHDB-2834
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2834
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Nick Vatamaniuc
>            Priority: Blocker
>              Labels: has-pr
>             Fix For: 2.0.0
>
>
> This is related COUCHDB-2833.
> This was found investigating the failure of replication tests. Specifically 
> couch_replicator_large_atts_tests, the {local, remote} sub-case.
> The test sets up push replications from local to remote.
> Replication workers  have more than 1 document larger than 
> MAX_BULK_ATT_SIZE=64K.  They start pushing them to the target, using a 
> keep-alive connection (default  for HTTP 1.1), the first few pipelined 
> requests will go through using the same connection, then server will accept 
> the first PUT to …/docid?edits=false, then return Connection:close and close 
> the connection after the 201 Created result.  
> Server should not close request too early and instead keep it open longer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to