Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/670#discussion_r60447868
--- Diff: app/addons/components/react-components.react.jsx ---
@@ -1133,13 +1141,20 @@ define([
return null;
}
return (
- <i className="icon fonticon-ok-circled" />
+ <i className={"icon " + this.props.customIcon} />
);
},
render: function () {
return (
- <button onClick={this.props.onClick} type="submit" className="btn
btn-success save" id={this.props.id}>
+ <button
+ onClick={this.props.onClick}
+ type="submit"
+ data-id={this.props['data-id']}
+ className={'btn save ' + this.props.buttonType}
+ id={this.props.id}
+ style={this.props.style}
+ >
--- End diff --
Couple of minor things:
- ID isn't a required prop, so it may end up blank. Better to only add the
prop if defined.
- data-id doesn't have default prop value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
