Github user tonysun83 commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/114#issuecomment-213276613
@kxepal: I updated the code to reflect your suggestions above:
1) Keep max_document_size as actual limitiation
2) Add in use_max_document_size to see if we actually decide to verify the
body
3) After parsing the doc, the body is stored in #doc.body. We check the
size on this record field for comparison.
4) I moved the logic to verify the body size into updates only.
5) Multi_parts and _update also check #doc.body for size.
6) _bulk_doc extraction is only done when use_max_document_size is true.
7) Add testing for inline-attachments, multi-part/related,
multi-part/form-data. (The multi-part tests were ridiculously painful because
of all the boundary CRLF issues).
Let me know what you think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
