Github user nickva commented on the pull request:

    https://github.com/apache/couchdb-fabric/pull/47#issuecomment-213864498
  
    +1
    
    Verified this along with https://github.com/apache/couchdb-couch/pull/166 
and https://github.com/apache/couchdb-couch/pull/167
    
    Don't fully understand this code (if that is a hard requirement for +1-ing 
then disregard this).  However checked EUnit tests pass, saw new ones in fabric 
and couch, those pas, and most importantly verified function_clause error from 
https://issues.apache.org/jira/browse/COUCHDB-2863 doesn't happen anymore (they 
still happen on master as Jira issue describes).
    
    ```
    $ http 
'http://adm:pass@localhost:15984/db/doc?open_revs=["1-967a00dff5e02add41819138abb3284d";,
 "2-7051cbe5c8faecd085a3fa619e6e6337"]&latest=true'
    HTTP/1.1 200 OK
    Content-Type: multipart/mixed; boundary="958cf62657e616ab7d2e799d0d268bf6"
    Date: Sun, 24 Apr 2016 01:04:15 GMT
    Server: CouchDB/b49d069 (Erlang OTP/17)
    Transfer-Encoding: chunked
    
    --958cf62657e616ab7d2e799d0d268bf6
    Content-Type: application/json
    
    {"_id":"doc","_rev":"2-7051cbe5c8faecd085a3fa619e6e6337"}
    --958cf62657e616ab7d2e799d0d268bf6--
    ```
    Deleting the doc and getting latest works as expected as well:
    
    ```
    $ http delete 
http://adm:pass@localhost:15984/db/doc?rev=2-7051cbe5c8faecd085a3fa619e6e6337
    {
        "id": "doc",
        "ok": true,
        "rev": "3-7379b9e515b161226c6559d90c4dc49f"
    }
    $  http 
'http://localhost:15984/db/doc?open_revs=["1-967a00dff5e02add41819138abb3284d";, 
"2-7051cbe5c8faecd085a3fa619e6e6337"]&latest=true'
    HTTP/1.1 200 OK
    Content-Type: multipart/mixed; boundary="85b637594584dc5bb88940a5513ebc74"
    Date: Sun, 24 Apr 2016 01:32:20 GMT
    Server: CouchDB/b49d069 (Erlang OTP/17)
    Transfer-Encoding: chunked
    
    --85b637594584dc5bb88940a5513ebc74
    Content-Type: application/json
    
    {"_id":"doc","_rev":"3-7379b9e515b161226c6559d90c4dc49f","_deleted":true}
    --85b637594584dc5bb88940a5513ebc74--
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to